06/23 Fix High-impact issues

2026-06-23 17:32:19 -04:00
parent 32caf735e8
commit a1afea095d
4 changed files with 50 additions and 22 deletions
@@ -277,13 +277,21 @@ actor APIClient {

    // ── Notification polling (Phase C) ────────────────────────────────────

+    // Shared formatter for the ?since= query parameter.
+    // DateFormatter init is expensive — creating one per fetchNotifications()
+    // call (every 60 seconds) adds unnecessary allocations on the sync cycle.
+    private static let notifSinceFmt: DateFormatter = {
+        let f = DateFormatter()
+        f.locale     = Locale(identifier: "en_US_POSIX")
+        f.dateFormat = "yyyy-MM-dd'T'HH:mm:ss"
+        return f
+    }()
+
    /// Fetch notifications, optionally scoped to those created after `since`.
    func fetchNotifications(since: Date? = nil) async throws -> [APINotification] {
        var ep = "/api/v1/notifications"
        if let since {
-            let fmt = DateFormatter()
-            fmt.dateFormat = "yyyy-MM-dd'T'HH:mm:ss"
-            ep += "?since=\(fmt.string(from: since))"
+            ep += "?since=\(Self.notifSinceFmt.string(from: since))"
        }
        let result: APINotificationsResponseData = try await request(ep)
        return result.notifications