Aug 19 - Re-evaluation

tests/test_external_inspector.py

@@ -116,7 +116,9 @@ def test_is_external_inspector_distinguishes_the_two(client):
 
 def test_role_label_renders_display_name(client):
     env = _seed()
-    assert env['external'].role_label == 'External Inspector'
+    # phase51 renamed the LABEL only — the role value is still
+    # 'external_inspector' (see User.ROLE_LABELS).
+    assert env['external'].role_label == 'Customer Inspector'
     assert env['internal'].role_label == 'Inspector'
 
 

tests/test_ui_theme.py

@@ -257,4 +257,4 @@ def test_theme_votes_renders_for_admin(client):
     assert resp.status_code == 200
     body = resp.get_data(as_text=True)
     # MT-15's ROLE_LABELS must be used for the raw group_by role strings.
-    assert 'External Inspector' in body
+    assert 'Customer Inspector' in body