nngo/LT_Janitorial_Quality_Control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Jul 9 - Update the 'Handled by' more clear and understandable

Browse Source
This commit is contained in:
nngo
2026-07-09 10:49:55 -04:00
parent b2ac816bc2
commit f8807dc371
9 changed files with 40 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+3 -1
View File
@@ -256,10 +256,12 @@ issues: id, inspection_id (nullable), area_id, facility_id (nullable), severity
| Value | Meaning | Detail fields | `assigned_to` role |
|---|---|---|---|
| `internal` (default) | Our staff | — (the assignee IS the handler) | the handler |
| `internal` (default) | Janitorial Staff (our crew) | — (the assignee IS the handler) | the handler |
| `facility` | The facility's own staff | `facility_handler_name/contact/notes` (free text) | internal **follow-up owner** |
| `vendor` | External contractor | `vendor_name/contact/notes` (Phase 26) | internal **follow-up owner** |
**Display labels are perspective-neutral** (they read the same for staff and customers) with a descriptor line under the selector and a tooltip on badges: `internal` → **"Janitorial Staff"** ("Our janitorial crew handles it."), `facility` → **"Facility Staff"** ("The facility's own on-site staff handle it."), `vendor` → **"External Vendor"** ("An outside contractor handles it."). Labels/descriptions live in `Issue.HANDLER_LABELS` / `HANDLER_DESCRIPTIONS`, the WTForms `handler_type` choices, and the `HANDLER_DESC` JS map in both issue templates — keep these in sync. Do **not** use viewer-relative words like "Our"/"Your" for the stored categories.
`assigned_to` (a JQC User) is **always** available: it is the handler for `internal`, and the internal follow-up owner (e.g. the inspector who verifies/updates) for `facility`/`vendor`. Settable in **two places**, both with a "Handled By" selector that reveals the facility or vendor sub-fields via JS:
- **Log New Issue** form (`issues/form.html`) — at creation, for non-customer staff. Customer-created issues stay `internal` (the handler UI is hidden for them, same as `assigned_to`).
- **Update Issue** panel on the issue detail page (`issues/view.html`) — triage after creation.
app/models/issue.py
+8 -2
View File
@@ -115,15 +115,21 @@ class Issue(db.Model):
return self.followers.filter_by(user_id=user.id).first() is not None
# Human-readable label for the handler category (phase35).
# Perspective-neutral wording so it reads the same for staff and customers.
HANDLER_LABELS = {
'internal': 'Our Staff',
'internal': 'Janitorial Staff',
'facility': 'Facility Staff',
'vendor': 'External Vendor',
}
HANDLER_DESCRIPTIONS = {
'internal': 'Our janitorial crew handles it.',
'facility': "The facility's own on-site staff handle it.",
'vendor': 'An outside contractor handles it.',
}
@property
def handler_label(self):
return self.HANDLER_LABELS.get(self.handler_type or 'internal', 'Our Staff')
return self.HANDLER_LABELS.get(self.handler_type or 'internal', 'Janitorial Staff')
@property
def resolved_facility(self):
app/templates/issues/form.html
+8
View File
@@ -41,6 +41,7 @@
<div class="mb-3">
{{ form.handler_type.label(class="form-label fw-semibold") }}
{{ form.handler_type(class="form-select", id="handler_type_select") }}
<div class="form-text" id="handler_desc"></div>
</div>
<div class="mb-3">
<label class="form-label fw-semibold" id="assigned_to_label">Assign To</label>
@@ -157,6 +158,11 @@
// ── "Handled By" — reveal the facility/vendor sub-block + relabel assignee ──
var handlerSelect = document.getElementById('handler_type_select');
var HANDLER_DESC = {
'internal': 'Our janitorial crew handles it.',
'facility': "The facility's own on-site staff handle it.",
'vendor': 'An outside contractor handles it.'
};
function syncHandlerUI() {
if (!handlerSelect) { return; }
var v = handlerSelect.value;
@@ -164,6 +170,8 @@
var venBlock = document.getElementById('vendor_block');
if (facBlock) { facBlock.style.display = (v === 'facility') ? '' : 'none'; }
if (venBlock) { venBlock.style.display = (v === 'vendor') ? '' : 'none'; }
var desc = document.getElementById('handler_desc');
if (desc) { desc.textContent = HANDLER_DESC[v] || ''; }
var label = document.getElementById('assigned_to_label');
var help = document.getElementById('assigned_to_help');
if (label) {
app/templates/issues/list.html
+1 -1
View File
@@ -86,7 +86,7 @@
<label class="form-label small mb-1">Handled By</label>
<select name="handler_type" class="form-select form-select-sm">
<option value="">All Handlers</option>
<option value="internal" {{ 'selected' if handler_filter == 'internal' }}>Our Staff</option>
<option value="internal" {{ 'selected' if handler_filter == 'internal' }}>Janitorial Staff</option>
<option value="facility" {{ 'selected' if handler_filter == 'facility' }}>Facility Staff</option>
<option value="vendor" {{ 'selected' if handler_filter == 'vendor' }}>External Vendor</option>
</select>
app/templates/issues/view.html
+12 -3
View File
@@ -76,11 +76,11 @@
<dt class="col-sm-3">Handled By</dt>
<dd class="col-sm-9">
{% if issue.handler_type == 'facility' %}
<span class="badge bg-info text-dark"><i class="bi bi-building me-1"></i>Facility Staff</span>
<span class="badge bg-info text-dark" title="The facility's own on-site staff handle it."><i class="bi bi-building me-1"></i>Facility Staff</span>
{% elif issue.handler_type == 'vendor' %}
<span class="badge bg-warning text-dark"><i class="bi bi-person-gear me-1"></i>External Vendor</span>
<span class="badge bg-warning text-dark" title="An outside contractor handles it."><i class="bi bi-person-gear me-1"></i>External Vendor</span>
{% else %}
<span class="badge bg-primary"><i class="bi bi-people me-1"></i>Our Staff</span>
<span class="badge bg-primary" title="Our janitorial crew handles it."><i class="bi bi-people me-1"></i>Janitorial Staff</span>
{% endif %}
</dd>
@@ -373,6 +373,7 @@
<div class="mb-3">
{{ form.handler_type.label(class="form-label fw-semibold") }}
{{ form.handler_type(class="form-select", id="handler_type_select") }}
<div class="form-text" id="handler_desc"></div>
</div>
{% endif %}
@@ -549,6 +550,11 @@
// ── "Handled By" — show the relevant sub-block (facility vs vendor) and
// relabel the assignee as a follow-up owner for facility/vendor. ──
var handlerSelect = document.getElementById('handler_type_select');
var HANDLER_DESC = {
'internal': 'Our janitorial crew handles it.',
'facility': "The facility's own on-site staff handle it.",
'vendor': 'An outside contractor handles it.'
};
function syncHandlerUI() {
if (!handlerSelect) { return; }
var v = handlerSelect.value;
@@ -557,6 +563,9 @@
if (facBlock) { facBlock.style.display = (v === 'facility') ? '' : 'none'; }
if (venBlock) { venBlock.style.display = (v === 'vendor') ? '' : 'none'; }
var desc = document.getElementById('handler_desc');
if (desc) { desc.textContent = HANDLER_DESC[v] || ''; }
var label = document.getElementById('assigned_to_label');
var help = document.getElementById('assigned_to_help');
if (label) {
app/utils/forms.py
+2 -2
View File
@@ -173,7 +173,7 @@ class IssueForm(FlaskForm):
assigned_to = SelectField('Assign To', coerce=int, validators=[Optional()])
# Who handles the issue (phase35) — set at creation by staff
handler_type = SelectField('Handled By', choices=[
('internal', 'Our Staff'),
('internal', 'Janitorial Staff'),
('facility', 'Facility Staff'),
('vendor', 'External Vendor'),
], validators=[Optional()])
@@ -199,7 +199,7 @@ class IssueUpdateForm(FlaskForm):
])
# Who handles the issue (phase35)
handler_type = SelectField('Handled By', choices=[
('internal', 'Our Staff'),
('internal', 'Janitorial Staff'),
('facility', 'Facility Staff'),
('vendor', 'External Vendor'),
], validators=[Optional()])
docs/manual_updates_customer.md
+3 -3
View File
@@ -68,9 +68,9 @@ notified immediately. You'll see a confirmation message when it's received.
When you view an issue, it now shows **Handled By**, indicating who is
responsible for resolving it:
- **Our Staff** — a member of the janitorial quality-control team.
- **Facility Staff** — the facility's own on-site staff are handling it.
- **External Vendor** — an outside contractor has been engaged.
- **Janitorial Staff** — our janitorial crew handles it.
- **Facility Staff** — the facility's own on-site staff handle it.
- **External Vendor** — an outside contractor handles it.
In every case, one of our team members remains the **follow-up owner** who
verifies the work and updates the issue. You do not set this field — it is
docs/manual_updates_inspector_mobile.md
+1 -1
View File
@@ -10,7 +10,7 @@ unchanged:
- **Scheduled inspections** — created and executed through the web app. The iPad
app has no scheduled-inspection list or "Start from schedule" action.
- **Issue "Handled By" (Our Staff / Facility Staff / External Vendor)** — set and
- **Issue "Handled By" (Janitorial Staff / Facility Staff / External Vendor)** — set and
displayed on the web only. The mobile issue screens are unchanged.
- **Facility QR codes / occupant report-a-problem** — a public web page; not part
of the inspector app.
docs/manual_updates_web_inspector.md
+2 -2
View File
@@ -61,8 +61,8 @@ who follows up:
| Handled By | Meaning |
|---|---|
| **Our Staff** | A JQC team member resolves it. |
| **Facility Staff** | The facility's own staff handle it (their contact is recorded on the issue). |
| **Janitorial Staff** | Our janitorial crew resolves it. |
| **Facility Staff** | The facility's own on-site staff handle it (their contact is recorded on the issue). |
| **External Vendor** | An outside contractor handles it (vendor details are recorded on the issue). |
Regardless of who does the work, **one of our staff is always the follow-up